fix(frontend): keep integer property fields editable by replacing the crashing Formly number parser#6058
Open
yangzhang75 wants to merge 1 commit into
Open
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6058 +/- ##
============================================
+ Coverage 56.37% 56.52% +0.14%
Complexity 2992 2992
============================================
Files 1129 1132 +3
Lines 43802 44349 +547
Branches 4743 4836 +93
============================================
+ Hits 24695 25067 +372
- Misses 17658 17822 +164
- Partials 1449 1460 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/request-review @mengw15 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a frontend regression where typing into integer/number operator property fields (e.g., Limit) stops committing changes due to @ngx-formly/core’s json-schema numeric parser doing DOM access (.validity.badInput) that crashes with ng-zorro’s nz-input-number.
Changes:
- Introduce a DOM-free, null-safe numeric parser (
parseNumericInput) and a helper to swap it in for numeric Formly fields (applySafeNumericParser). - Hook the safe parser replacement into the JSONSchema→Formly mapping path for operator properties.
- Add unit tests covering numeric parsing edge cases and ensuring the replacement avoids the prior crash behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.ts | Applies the safe numeric parser during JSON schema → Formly field mapping for operator property forms. |
| frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/numeric-input-parser.util.ts | Adds a null-safe numeric parser and a helper to replace Formly’s crash-prone numeric parser without DOM access. |
| frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/numeric-input-parser.util.spec.ts | Adds unit tests validating numeric parsing behavior and safe parser replacement semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+61
| export function applySafeNumericParser(field: FormlyFieldConfig): void { | ||
| if (field.parsers && field.parsers.length > 0) { | ||
| field.parsers = [value => parseNumericInput(value)]; | ||
| } | ||
| } |
yangzhang75
force-pushed
the
fix/integer-property-input-parser
branch
3 times, most recently
from
18b5b7d to
b95ec7b
Compare
… crashing Formly number parser
@ngx-formly/core's json-schema integer/number parser reads
document.querySelector('#'+field.id).validity.badInput, assuming the id is on the
native <input>. ng-zorro's nz-input-number puts the id on its host element, which has
no .validity, so the parser throws 'Cannot read properties of undefined (reading
badInput)' whenever the parsed value is null (an intermediate state while typing).
Typed edits then never commit and the field is stuck (only the +/- steppers work).
Replace the numeric fields' parser in jsonSchemaMapIntercept with a null-safe parser
that does no DOM access.
yangzhang75
force-pushed
the
fix/integer-property-input-parser
branch
from
b95ec7b to
fdd2350
Compare
Yicong-Huang
reviewed
Jul 5, 2026
Comment on lines
+25
to
+31
| * It replaces @ngx-formly/core's json-schema integer/number parser, which reads | ||
| * `document.querySelector('#' + field.id).validity.badInput`. That code assumes the | ||
| * field id is on the native `<input>`, but ng-zorro's `nz-input-number` puts the id | ||
| * on its host element (which has no `.validity`), so the parser throws | ||
| * "Cannot read properties of undefined (reading 'badInput')" and typed edits never | ||
| * commit. This version does no DOM access: it just converts the value to a number, or | ||
| * null when it is empty/undefined/not a number. |
Contributor
There was a problem hiding this comment.
it is often not a good idea to patch the dependency lib unless absolutely necessary. did we check if formly has this bug fixed in a newer version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Fixes typed edits being ignored on integer/number operator property fields (reproduced
on the Limit operator): the field gets stuck and only the +/- steppers work.
Root cause:
@ngx-formly/core's json-schema integer/number parser readsdocument.querySelector('#' + field.id).validity.badInput, assuming the id is on thenative
<input>. ng-zorro'snz-input-numberputs the id on its host element (whichhas no
.validity), so the parser throwsCannot read properties of undefined (reading 'badInput')whenever the parsed value is null (an intermediate state whiletyping). The typed value then never commits.
This replaces that parser, for numeric fields only, with a null-safe parser that does
no DOM access (
applySafeNumericParserinjsonSchemaMapIntercept). The stepper pathwas unaffected and keeps working.
Any related issues, documentation, discussions?
Closes #6054
How was this PR tested?
parseNumericInput(numeric/decimal/negative/whitespace/empty/non-numeric/DOM-safety) and
applySafeNumericParser(replaces the crash-prone parser,null-safe on the clear-field case, leaves non-numeric fields untouched) — 12 tests.
OperatorPropertyEditFrameComponentspec still passes.and the console
badInputTypeError is gone.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)